fix: merge query for no-hash routes #286
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there :)
I wanted to propose a fix for a particular use-case with client routes.
What I found is that when using hash router, everything works fine when specifying query in
route
attribute, though if the client has standard routing, then query params are encoded in pathname, breaking the iframe url.The proposal here would be to merge query params both from host, and specified route, and then assign
pathname
andsearch
with the computed values.I also added two tests but would be happy to discuss about it if you feel that should not be a supported use-case.