Support building web-workers in the example app #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows ifc-cli to serve static files in addition to acting as a proxy to a dev server, for simpler client-embedding setups. We have also updated the example app to use this hosting in conjunction with build changes that make it easier to build both an app js file and web workers for future IFC features
MattCheely
requested review from
jordanstith15,
daragh-king-genesys and
katie-bobbe-genesys
MattCheely
commented
Jan 9, 2025
| // Load polyfills required for IE11 | ||
| import "@babel/polyfill"; | ||
| import "custom-event-polyfill"; | ||
| import "url-polyfill"; |
There was a problem hiding this comment.
I also removed these old IE11 polyfills while I was working in these files
katie-bobbe-genesys
approved these changes
Jan 9, 2025
thomas-c-dillon
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to enable the web-worker builds, ifc-cli was updated to be able to serve static files. This should also have some utility for users in being able to test/use pre-built client applications in ifc-cli.