[NLU-4815] - Fix for thousand seperators "1000,50" resolving as 1000,00 and 50,00 separately for German #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conor-Keaney
requested review from
sanhal,
kevinwalshgen,
samhickey25,
colm-dillon,
andrew-gradinari,
BobbyMartins5 and
CiaraCrowe
colm-dillon
approved these changes
Feb 6, 2025
Python/libraries/recognizers-number/recognizers_number/resources/german_numeric.py
Show resolved
Hide resolved
Conor-Keaney
commented
Feb 10, 2025
Python/Jenkinsfile
Outdated
There was a problem hiding this comment.
Tested this in build 526 - https://jenkins.ininica.com/job/NLU/job/Recognizers-Text/526/
andrew-gradinari
approved these changes
Feb 10, 2025
kevinwalshgen
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the thousand separator of a full stop optional when capturing numbers > 999 that also has decimal numbers