Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PA-5999) Use pl-autotools instead of autoconf and automake for SLES-11 #792

Merged
merged 1 commit into from
Feb 20, 2024
Merged

(PA-5999) Use pl-autotools instead of autoconf and automake for SLES-11 #792

merged 1 commit into from
Feb 20, 2024

Conversation

shubhamshinde360
Copy link
Contributor

  • For Puppet8, we use ruby3 which requires autoconf to be >= 2.67, but SLES-11 supports only upto 2.63. So, we use pl-autotools for both puppet7 and puppet8 for consistency.

@shubhamshinde360
(PA-5999) Use pl-autotools instead of autoconf and automake for SLES-11
e832cd4 
 - For Puppet8, we use ruby3 which requires autoconf to be >= 2.67, but SLES-11 supports only upto 2.63. So, we use pl-autotools for both puppet7 and puppet8 for consistency.
@shubhamshinde360 shubhamshinde360 marked this pull request as ready for review February 20, 2024 10:02
@shubhamshinde360 shubhamshinde360 requested review from a team as code owners February 20, 2024 10:02
@amitkarsale
Copy link
Contributor

amitkarsale commented Feb 20, 2024 •
edited
Loading

I guess we have a dependency of autoconf(or autoreconf). Omitting it is failing for autoreconf in main.

@joshcooper joshcooper merged commit ad6b41a into puppetlabs:master Feb 20, 2024
3 checks passed
@joshcooper joshcooper added the skip changelog Will be excluded from changelog label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshcooper joshcooper joshcooper approved these changes

Assignees
No one assigned
Labels
skip changelog Will be excluded from changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shubhamshinde360 @amitkarsale @joshcooper