Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(CAT-2148) Update bundled templates known issue #1431

Merged
merged 2 commits into from
Jan 30, 2025
Merged

(CAT-2148) Update bundled templates known issue #1431

merged 2 commits into from
Jan 30, 2025

Conversation

david22swan
Copy link
Member

@david22swan david22swan commented Jan 30, 2025 •
edited
Loading

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@david22swan david22swan added maintenance Internal maintenance work that shouldn't appear in the changelog documentation labels Jan 30, 2025
@david22swan david22swan requested a review from a team as a code owner January 30, 2025 11:15
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.49%. Comparing base (b5b77c1) to head (90f4a2d).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1431   +/-   ##
=======================================
  Coverage   88.49%   88.49%           
=======================================
  Files         127      127           
  Lines        5320     5320           
=======================================
  Hits         4708     4708           
  Misses        612      612

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gavindidrichsen
gavindidrichsen approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@gavindidrichsen gavindidrichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavindidrichsen gavindidrichsen merged commit 4f564cb into main Jan 30, 2025
12 checks passed
@gavindidrichsen gavindidrichsen deleted the known_issue branch January 30, 2025 13:02
@david22swan david22swan changed the title Known issue (CAT-2148) Update bundled templates known issue Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavindidrichsen gavindidrichsen gavindidrichsen approved these changes

Assignees
No one assigned
Labels
documentation maintenance Internal maintenance work that shouldn't appear in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david22swan @gavindidrichsen