Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-2093) Enable shellcheck in CI #1404

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

LukasAud
Copy link
Contributor

@LukasAud LukasAud commented Oct 9, 2024

Following the implementation of shellcheck in the CI, we are enabling it in the repositories we consider necessary.

Following the implementation of shellcheck in the CI, we are enabling
it in the repositories we consider necessary.
@LukasAud LukasAud added the maintenance Internal maintenance work that shouldn't appear in the changelog label Oct 9, 2024
@LukasAud LukasAud marked this pull request as ready for review October 9, 2024 08:17
@LukasAud LukasAud requested a review from a team as a code owner October 9, 2024 08:17
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.49%. Comparing base (e8cd9ae) to head (9275a96).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1404   +/-   ##
=======================================
  Coverage   88.49%   88.49%           
=======================================
  Files         127      127           
  Lines        5329     5329           
=======================================
  Hits         4716     4716           
  Misses        613      613           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LukasAud LukasAud changed the title (CAT-2013) Enable shellcheck in CI (CAT-2093) Enable shellcheck in CI Oct 14, 2024
Copy link
Contributor

@gavindidrichsen gavindidrichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gavindidrichsen gavindidrichsen merged commit 5351972 into main Oct 14, 2024
11 of 12 checks passed
@gavindidrichsen gavindidrichsen deleted the CAT-2013-Add_shellcheck branch October 14, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Internal maintenance work that shouldn't appear in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants