This repository has been archived by the owner on Jan 15, 2025. It is now read-only.
(PE-36763) Migrate CURLOPT_PROTOCOLS{,_STR} #339
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlehman
commented
Jan 16, 2024
| @@ -3,7 +3,7 @@ | |||
| # not set CMAKE_CXX_FLAGS globally because gtest is not warning-clean. | |||
| if ("${CMAKE_CXX_COMPILER_ID}" MATCHES "\\w*Clang") | |||
| if (ENABLE_CXX_WERROR) | |||
| set(CMAKE_CXX_FLAGS "-Werror ${CMAKE_CXX_FLAGS}") | |||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}") | |||
There was a problem hiding this comment.
This can be removed in the final merge. I disabled this before making any changes just to get the main branch to compile.
|
Closing in favor of leatherman#340 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated
CURLOPT_PROTOCOLSoption and replaces it with the newCURLOPT_PROTOCOLS_STRoption.Jira: https://perforce.atlassian.net/browse/PE-36763
Testing
This builds and the unit tests all pass
DO NOT MERGE UNTIL: all consumers of leatherman (pxp-agent, etc.) have been updated to use this option.