Goint toward OpenJDK 17 compatibility #137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardening version regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
capsule is packaged in Debian, where we are currently checking if building packages is still possible with OpenJDK 17, whereas we currently use OpenJDK 11. Hence the bug report
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1011924
concerning capsule. The current pull request solves the issue in the bug, but then I get 40 failing tests, please see the enclosed log.
failingTests_openJDK17_20220529.txt
I guess there are various reasons why the tests fail, for instance testWrapperCapsuleAgent certainly fails because of the illegal reflective access attempt in CapsuleTestUtils.accessible (which "only" issued a warning with previous JDKs). For other tests, I admit I have not gone into details that much.
I will be happy to provide you with more details if I can and I would appreciate any help to achieve OpenJDK 17 compatibility if you have time for it,
Best,
Pierre