Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update more python templates to use dictionary literals #827

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

julienp
Copy link
Contributor

@julienp julienp commented Aug 27, 2024

With type checking for dictionary literals, we now prefer this style over args classes pulumi/pulumi#12689

Ref pulumi/examples#1667

@julienp julienp marked this pull request as ready for review August 27, 2024 16:08
@julienp julienp requested a review from a team August 27, 2024 16:08
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

kubernetes-python/__main__.py Show resolved Hide resolved
With type checking for dictionary literals, we now prefer this style over args classes pulumi/pulumi#12689
@julienp julienp force-pushed the julienp/typeddicts branch from 62dc4d8 to 26e5350 Compare August 28, 2024 09:20
@julienp julienp enabled auto-merge August 28, 2024 09:20
@julienp julienp merged commit 170e2b3 into master Aug 28, 2024
6 checks passed
@julienp julienp deleted the julienp/typeddicts branch August 28, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants