Update secrets-provider to BucketV2 #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🍹 The Update for pulumi/k8s-ci-cluster/ead58a9cf46c29eefe57b4326b1ea40fc3d0ee90-207 was successful. Resource Changes Name Type Operation
+ gke pulumi:providers:kubernetes create
+ k8s-ci-cluster-ead58a9cf46c29eefe57b4326b1ea40fc3d0ee90-207 pulumi:pulumi:Stack create
+ multicloud pulumi-kubernetes:ci:GkeCluster create
+ password random:index/randomPassword:RandomPassword create
+ ephemeral-ci-cluster gcp:container/cluster:Cluster create
+ primary-node-pool gcp:container/nodePool:NodePool create
|
corymhall
previously requested changes
Oct 3, 2024
flostadler
reviewed
Oct 3, 2024
flostadler
reviewed
Oct 3, 2024
t0yv0
force-pushed
the
t0yv0/update-policy-packs-aws-ts-finops-bucketv2
branch
from
93c2196 to
862712b
Compare
|
Great comments team, zooming out a bit I read the example README carefully and realized the example is not about a Bucket at all. I've therefore simplified it to a bare minimum, and added a warning note for people not to blindly store secrets in bucket objects as that is not what is being recommended here. PTAL. |
|
🍹 The Update for pulumi/k8s-ci-cluster/45f7f58306a5c2b2874773b019f6187d5732f321-241 was successful. Resource Changes Name Type Operation
+ k8s-ci-cluster-45f7f58306a5c2b2874773b019f6187d5732f321-241 pulumi:pulumi:Stack create
+ multicloud pulumi-kubernetes:ci:GkeCluster create
+ password random:index/randomPassword:RandomPassword create
+ ephemeral-ci-cluster gcp:container/cluster:Cluster create
+ primary-node-pool gcp:container/nodePool:NodePool create
+ gke pulumi:providers:kubernetes create
|
|
🍹 The Destroy for pulumi/k8s-ci-cluster/45f7f58306a5c2b2874773b019f6187d5732f321-241 was successful. Resource Changes Name Type Operation
- password random:index/randomPassword:RandomPassword delete
- k8s-ci-cluster-45f7f58306a5c2b2874773b019f6187d5732f321-241 pulumi:pulumi:Stack delete
- gke pulumi:providers:kubernetes delete
- primary-node-pool gcp:container/nodePool:NodePool delete
- ephemeral-ci-cluster gcp:container/cluster:Cluster delete
- multicloud pulumi-kubernetes:ci:GkeCluster delete
|
corymhall
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: pulumi/home#3631