Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update aws-ts-static-website to BucketV2 #1699

Merged
merged 7 commits into from
Oct 4, 2024
Merged

Update aws-ts-static-website to BucketV2 #1699

merged 7 commits into from
Oct 4, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Sep 19, 2024

Re: pulumi/home#3631

@t0yv0 t0yv0 requested a review from interurban September 19, 2024 19:07
@pulumi-staging Pulumi Staging
Copy link

🍹 The Update for pulumi/k8s-ci-cluster/9a4a89304bd82f376f7ee959e7eda230d68f253f-201 was successful.

Resource Changes

    Name                                                         Type                                        Operation
+   primary-node-pool                                            gcp:container/nodePool:NodePool             create
+   gke                                                          pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-9a4a89304bd82f376f7ee959e7eda230d68f253f-201  pulumi:pulumi:Stack                         create
+   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             create
+   password                                                     random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               create

@pulumi-staging Pulumi Staging
Copy link

🍹 The Destroy for pulumi/k8s-ci-cluster/9a4a89304bd82f376f7ee959e7eda230d68f253f-201 was successful.

Resource Changes

    Name                                                         Type                                        Operation
-   gke                                                          pulumi:providers:kubernetes                 delete
-   primary-node-pool                                            gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               delete
-   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             delete
-   password                                                     random:index/randomPassword:RandomPassword  delete
-   k8s-ci-cluster-9a4a89304bd82f376f7ee959e7eda230d68f253f-201  pulumi:pulumi:Stack                         delete

@pulumi-staging Pulumi Staging
Copy link

pulumi-staging bot commented Oct 2, 2024

🍹 The Update for pulumi/k8s-ci-cluster/55edda250d2db0f9881bef57b29f9f541ad52186-237 was successful.

Resource Changes

    Name                                                         Type                                        Operation
+   primary-node-pool                                            gcp:container/nodePool:NodePool             create
+   gke                                                          pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-55edda250d2db0f9881bef57b29f9f541ad52186-237  pulumi:pulumi:Stack                         create
+   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             create
+   password                                                     random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               create

@pulumi-staging Pulumi Staging
Copy link

pulumi-staging bot commented Oct 2, 2024

🍹 The Destroy for pulumi/k8s-ci-cluster/55edda250d2db0f9881bef57b29f9f541ad52186-237 was successful.

Resource Changes

    Name                                                         Type                                        Operation
-   k8s-ci-cluster-55edda250d2db0f9881bef57b29f9f541ad52186-237  pulumi:pulumi:Stack                         delete
-   gke                                                          pulumi:providers:kubernetes                 delete
-   primary-node-pool                                            gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               delete
-   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             delete
-   password                                                     random:index/randomPassword:RandomPassword  delete

corymhall
corymhall requested changes Oct 3, 2024
View reviewed changes
aws-ts-static-website/index.ts Outdated Show resolved Hide resolved
flostadler
flostadler reviewed Oct 3, 2024
View reviewed changes
aws-ts-static-website/index.ts Outdated
errorDocument: "404.html",
},
});
const contentBucket = new aws.s3.BucketV2("contentBucket", {bucket: config.targetDomain});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have to make this bucket publicly readable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's right. The example doesn't provision otherwise. Checking.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we do since we are configuring public access through a CloudFront distribution with accesses the bucket via an OIC and bucket policies.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your intuition is right. I mixed up some test results. It works without it, therefore I will remove.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think sadly ACL is still needed for the logs bucket. Just not the content bucket.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me update Python to match.

aws-ts-static-website/index.ts Show resolved Hide resolved
@t0yv0 t0yv0 force-pushed the t0yv0/update-aws-ts-static-website-bucketv2 branch from c4b37c5 to 8379046 Compare October 3, 2024 14:55
@t0yv0 t0yv0 requested review from corymhall and flostadler October 3, 2024 14:55
t0yv0
t0yv0 commented Oct 3, 2024
View reviewed changes
aws-py-static-website/__main__.py
@@ -92,7 +92,6 @@ def bucket_object_converter(filepath):
content_file = pulumi_aws.s3.BucketObject(
relative_path,
key=relative_path,
acl='public-read',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also addressing PR feedback for the example that's the same example translated to Python.

@pulumi-staging Pulumi Staging
Copy link

pulumi-staging bot commented Oct 3, 2024

🍹 The Update for pulumi/k8s-ci-cluster/3a291f10919f6301cc8da2791c28a7dc484af4d4-240 was successful.

Resource Changes

    Name                                                         Type                                        Operation
+   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             create
+   password                                                     random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               create
+   primary-node-pool                                            gcp:container/nodePool:NodePool             create
+   gke                                                          pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-3a291f10919f6301cc8da2791c28a7dc484af4d4-240  pulumi:pulumi:Stack                         create

@pulumi-staging Pulumi Staging
Copy link

pulumi-staging bot commented Oct 3, 2024

🍹 The Destroy for pulumi/k8s-ci-cluster/3a291f10919f6301cc8da2791c28a7dc484af4d4-240 was successful.

Resource Changes

    Name                                                         Type                                        Operation
-   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             delete
-   password                                                     random:index/randomPassword:RandomPassword  delete
-   k8s-ci-cluster-3a291f10919f6301cc8da2791c28a7dc484af4d4-240  pulumi:pulumi:Stack                         delete
-   gke                                                          pulumi:providers:kubernetes                 delete
-   primary-node-pool                                            gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               delete

@t0yv0
Copy link
Member Author

t0yv0 commented Oct 3, 2024

PTAL.

corymhall
corymhall previously requested changes Oct 3, 2024
View reviewed changes
aws-ts-static-website/index.ts Outdated
errorDocument: "404.html",
},
});
const contentBucket = new aws.s3.BucketV2("contentBucket", {bucket: config.targetDomain});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we do since we are configuring public access through a CloudFront distribution with accesses the bucket via an OIC and bucket policies.

@t0yv0 t0yv0 force-pushed the t0yv0/update-aws-ts-static-website-bucketv2 branch from ab67e3a to 2a09731 Compare October 4, 2024 18:01
@t0yv0 t0yv0 requested a review from corymhall October 4, 2024 18:01
@pulumi-staging Pulumi Staging
Copy link

pulumi-staging bot commented Oct 4, 2024

🍹 The Update for pulumi/k8s-ci-cluster/6669dfda1829c6e781415dbe718e4115f5883880-245 was successful.

Resource Changes

    Name                                                         Type                                        Operation
+   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               create
+   primary-node-pool                                            gcp:container/nodePool:NodePool             create
+   gke                                                          pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-6669dfda1829c6e781415dbe718e4115f5883880-245  pulumi:pulumi:Stack                         create
+   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             create
+   password                                                     random:index/randomPassword:RandomPassword  create

@pulumi-staging Pulumi Staging
Copy link

pulumi-staging bot commented Oct 4, 2024

🍹 The Update for pulumi/k8s-ci-cluster/91ae2cac0d9ffbe8010864df85b9dfbac9763a1a-246 was successful.

Resource Changes

    Name                                                         Type                                        Operation
+   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             create
+   password                                                     random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               create
+   primary-node-pool                                            gcp:container/nodePool:NodePool             create
+   gke                                                          pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-91ae2cac0d9ffbe8010864df85b9dfbac9763a1a-246  pulumi:pulumi:Stack                         create

@pulumi-staging Pulumi Staging
Copy link

pulumi-staging bot commented Oct 4, 2024

🍹 The Update for pulumi/k8s-ci-cluster/63f734d71be5dc8939127939c99405bb00742204-247 was successful.

Resource Changes

    Name                                                         Type                                        Operation
+   primary-node-pool                                            gcp:container/nodePool:NodePool             create
+   gke                                                          pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-63f734d71be5dc8939127939c99405bb00742204-247  pulumi:pulumi:Stack                         create
+   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             create
+   password                                                     random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               create

@pulumi-staging Pulumi Staging
Copy link

pulumi-staging bot commented Oct 4, 2024

🍹 The Destroy for pulumi/k8s-ci-cluster/6669dfda1829c6e781415dbe718e4115f5883880-245 was successful.

Resource Changes

    Name                                                         Type                                        Operation
-   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             delete
-   password                                                     random:index/randomPassword:RandomPassword  delete
-   k8s-ci-cluster-6669dfda1829c6e781415dbe718e4115f5883880-245  pulumi:pulumi:Stack                         delete
-   gke                                                          pulumi:providers:kubernetes                 delete
-   primary-node-pool                                            gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               delete

@pulumi-staging Pulumi Staging
Copy link

pulumi-staging bot commented Oct 4, 2024

🍹 The Destroy for pulumi/k8s-ci-cluster/91ae2cac0d9ffbe8010864df85b9dfbac9763a1a-246 was successful.

Resource Changes

    Name                                                         Type                                        Operation
-   gke                                                          pulumi:providers:kubernetes                 delete
-   primary-node-pool                                            gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               delete
-   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             delete
-   password                                                     random:index/randomPassword:RandomPassword  delete
-   k8s-ci-cluster-91ae2cac0d9ffbe8010864df85b9dfbac9763a1a-246  pulumi:pulumi:Stack                         delete

@pulumi-staging Pulumi Staging
Copy link

pulumi-staging bot commented Oct 4, 2024

🍹 The Destroy for pulumi/k8s-ci-cluster/63f734d71be5dc8939127939c99405bb00742204-247 was successful.

Resource Changes

    Name                                                         Type                                        Operation
-   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             delete
-   password                                                     random:index/randomPassword:RandomPassword  delete
-   k8s-ci-cluster-63f734d71be5dc8939127939c99405bb00742204-247  pulumi:pulumi:Stack                         delete
-   gke                                                          pulumi:providers:kubernetes                 delete
-   primary-node-pool                                            gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               delete

@t0yv0 t0yv0 dismissed corymhall’s stale review October 4, 2024 19:05

Addressed the request

@t0yv0 t0yv0 merged commit 54f59bf into master Oct 4, 2024
47 checks passed
@t0yv0 t0yv0 deleted the t0yv0/update-aws-ts-static-website-bucketv2 branch October 4, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjeffryes mjeffryes mjeffryes approved these changes

@interurban interurban Awaiting requested review from interurban

@flostadler flostadler Awaiting requested review from flostadler

@corymhall corymhall Awaiting requested review from corymhall

Assignees

@t0yv0 t0yv0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@t0yv0 @mjeffryes @flostadler @corymhall