Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improved region handling for langchain examples #1639

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Conversation

dirien
Copy link
Contributor

@dirien dirien commented May 20, 2024

This PR improves the region handling in the langchain examples. Before the region was hard-coded to eu-central-1, which is not ideal as not everyone is using this region.

@dirien dirien requested a review from aaronkao May 20, 2024 09:11
@dirien dirien self-assigned this May 20, 2024
@dirien dirien added this to the 0.105 milestone May 20, 2024
@dirien dirien changed the title fix: region handling fix: improved region handling for langchain examples May 20, 2024
@dirien dirien enabled auto-merge (squash) May 20, 2024 09:13
@dirien dirien requested a review from usrbinkat June 5, 2024 06:18
@dirien dirien requested a review from cnunciato June 9, 2024 09:17
@dirien dirien modified the milestones: 0.105, 0.106 Jun 10, 2024
@dirien dirien merged commit 530a7e1 into master Jun 24, 2024
49 of 51 checks passed
@dirien dirien deleted the region-handling branch June 24, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants