Update providers during perf measure #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🍹 The Update for pulumi/k8s-ci-cluster/0d986fc976039db30aba603701e612c8c2c73ea9-1677 was successful. Resource Changes Name Type Operation
+ primary-node-pool gcp:container/nodePool:NodePool create
+ gke pulumi:providers:kubernetes create
+ k8s-ci-cluster-0d986fc976039db30aba603701e612c8c2c73ea9-1677 pulumi:pulumi:Stack create
+ multicloud pulumi-kubernetes:ci:GkeCluster create
+ password random:index/randomPassword:RandomPassword create
+ ephemeral-ci-cluster gcp:container/cluster:Cluster create
|
cnunciato
approved these changes
Feb 6, 2024
|
🍹 The Destroy for pulumi/k8s-ci-cluster/0d986fc976039db30aba603701e612c8c2c73ea9-1677 was successful. Resource Changes Name Type Operation
- gke pulumi:providers:kubernetes delete
- primary-node-pool gcp:container/nodePool:NodePool delete
- ephemeral-ci-cluster gcp:container/cluster:Cluster delete
- multicloud pulumi-kubernetes:ci:GkeCluster delete
- password random:index/randomPassword:RandomPassword delete
- k8s-ci-cluster-0d986fc976039db30aba603701e612c8c2c73ea9-1677 pulumi:pulumi:Stack delete
|
|
Test failure appears unrelated, I think I can merge. I'll revert if something breaks in the metrics pipeline per se. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Python and TypeScript, provider references are floating, but for Go they are always pinned. As a result TestAccAwsGoS3Folder was always testing the performance of aws v6.0.2 not the later versions that shipped some performance improvements. Compensate for this in the benchmark by updating to latest.