Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploy with pulumi button to be more visible in dark mode #1569

Merged
merged 7 commits into from
Jan 31, 2024

Conversation

zchase
Copy link

@zchase zchase commented Jan 30, 2024

In dark mode the "Deploy with Pulumi" button can be hard to see:

deploy-with-pulumi-darkmode

This PR update the button to include a dark mode version:

deploywithpulumilight

I doubled checked the tutorial generation for the website and these images are not used so we should not have to deal with two buttons rendering on those pages.

Fixes: https://github.com/pulumi/marketing/issues/932
Part of: https://github.com/pulumi/marketing/issues/951

@zchase zchase changed the title Zchase/darkmode deploy button Update deploy with pulumi button to be more visible in dark mode Jan 30, 2024
Copy link
Contributor

@scottslowe scottslowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the first 124 files in this PR and didn't spot any errors or issues, so I'm approving the PR.

@zchase zchase merged commit 267aba1 into master Jan 31, 2024
51 checks passed
@zchase zchase deleted the zchase/darkmode-deploy-button branch January 31, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants