-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update programs to kubernetes 4.0.3 #1472
Conversation
@cnunciato Could you take a look at
|
@@ -1,57 +1,72 @@ | |||
module github.com/pulumi/examples/kubernetes-go-helm-release-wordpress | |||
|
|||
go 1.17 | |||
go 1.18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to bump this even more to the latest stable 1.21
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The go
version is inconsistent and quite old 1.13
at times. Looks like it was changed in some places. I'd suggest to bump them all to the latest stable version
Bumping this to M96 due to Helm v3 issue described above |
Update: it's not working, the behavior persists and is a bug: pulumi/pulumi-kubernetes#2638 @mnlumi @cnunciato How would you like to proceed? Wait for a fix for the bug and update all the examples in one swoop, or update the other examples and fix this one example later? |
@scottslowe At this point, the PR is now several releases behind for Kubernetes. My suggestion is to exclude the broken example while opening an issue to handle it separately. |
@mnlumi I'm good with that approach, assuming no one else has objections. |
@mnlumi Per Eric's e-mail, we'll leave this issue open to track resolution of the broken example. Just exclude the broken example from the PR to update the provider for all the rest of the examples. Once we have all tests passing, then we can merge that PR to get everything else updated. |
Closing as this as it is significantly out of date and a new pull request would be more efficient. @EronWright @mjeffryes - You may want to work with your team or @cnunciato to get these kubernetes examples updated to v4 instead of v3 and the latest pulumi versions as well. |
Resolves #1466