Change theme colour to purple #189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
confused-Techie
approved these changes
Mar 1, 2023
|
Does anyone else from @pulsar-edit/documentation want to take a review of this one or are we good to merge? |
|
Alright, with not much activity happening here, or seen on Discord, how do we feel about merging this one? |
|
I kinda liked the blue, but most people who commented seemed to like the purple, so sure. 👍 I think the majority has it (even if the sample size was pretty small). And we can always keep refreshing it as time goes on. |
|
Its very much just a temporary thing until we have our branding clear, I think its better than the green either way, |
meadowsys
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current theme colour (default theme green) is a bit jarring, especially with the purple home page. The original plan was to wait for the branding and do this in one go but that seems to be taking a while.
This is really just a "one size fits all" temporary fix, just one css value which affects a bunch of stuff such as the footer, the hero text, mouseover accents, hyperlinks etc.
This purple is the same one from the package Dracula theme (
#ae88e5). Suggestions welcome as this is very easy to change - for example I can see objection to how it looks on the light theme, maybe this should be darkened a tad?