[PULP-218] Add timeout to immediate tasks #6155
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedro-psb
changed the title
mdellweg
reviewed
Dec 17, 2024
Comment on lines
+62
to
+63
| signal.signal(signal.SIGALRM, timeout_handler) | ||
| signal.alarm(IMMEDIATE_TASK_TIMEOUT) |
There was a problem hiding this comment.
Oh, interesting.
This is quite close to low level process handling. I wonder if this might interfere with other uses of the signal handler.
Do you think we can instead require that all immediate tasks are async functions? We could then implement the timeout on the asyncio level with much more confidence.
There was a problem hiding this comment.
Do you think we can instead require that all immediate tasks are async functions? We could then implement the timeout on the asyncio level with much more confidence.
Yes. I dont have a good idea of how much friction this imposes, but that's definitely more safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.