Skip to content

[PULP-968] Exclude excessive fields from cv view #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdellweg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[PULP-968] Exclude excessive fields from cv view #2367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/+cv_list_oom.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Exclude some bloated fields by default from the collection version views.
15 changes: 15 additions & 0 deletions pulp_ansible/app/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,6 +665,21 @@ class CollectionVersionSerializer(ContentChecksumSerializer, CollectionVersionUp

creating = True

def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)
try:
request = self.context["request"]
if request.method != "GET":
return
except (AttributeError, TypeError, KeyError):
# The serializer was not initialized with request context.
return
query_params = request.query_params
if self.include_arg_name in query_params or self.exclude_arg_name in query_params:
return
for fieldname in ["files", "manifest", "docs_blob", "contents"]:
self.fields.pop(fieldname)

def validate(self, data):
"""Run super() validate if creating, else return data."""
# This validation is for creating CollectionVersions
Expand Down