Data users new design #1088
Merged
Data users new design #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorcorrea
force-pushed
the
984-data-users
branch
from
7feb951 to
ab866c8
Compare
hectorcorrea
force-pushed
the
984-data-users
branch
from
dbe24a6 to
7c9b7fb
Compare
hectorcorrea
commented
Dec 16, 2024
Comment on lines
193
to
195
| // Notice that we are keeping this JavaScript on the page rather than on application.js | ||
| // because otherwise we don't have access to $(elementId).autocomplete() | ||
| // This is due to the way we are loading the autocomplete plug-in outside of application.js |
There was a problem hiding this comment.
This is the reason I moved the script from application.js to the Rails view.
leefaisonr
approved these changes
Dec 16, 2024
kelynch
pushed a commit
that referenced
this pull request
Dec 17, 2024
* WIP * First sort-of runnig version. Still WIP but much more advanced * Got the delete to work, fixed a few validation issues. * Adjusted the save logic to account for the new way we represent RO vs RW users * Display the initial list of rw and ro users * Fix merge conflict * Minor clean up * Moved CSS to the application level * Started re-creating the data users tests * Adjusted test to use new HTML FORM keys * Bye byebug * Adjust the test for the new keys * Adjust the test for the new HTML FORM keys * Adjust test to new UI for data users * Added test for invalid data users entered * Removed commented lines
carolyncole
pushed a commit
that referenced
this pull request
Dec 17, 2024
* refreshing the logged out state of the home page * updating tests * Adjusted display for fixed margins width (#1130) * Fixed bug in download link in modal (#1131) * Fixed bug in download link in modal * Fixed breaking test --------- Co-authored-by: Robert-Anthony Lee-Faison <[email protected]> * WIP getting image flush to bottom of page * Fixed logged out layout, adjusted flash warning placement, fixed link color for logout button * Applied heading font across the application * Replaced image * Adjustments based on feedback from PO * Data users new design (#1088) * WIP * First sort-of runnig version. Still WIP but much more advanced * Got the delete to work, fixed a few validation issues. * Adjusted the save logic to account for the new way we represent RO vs RW users * Display the initial list of rw and ro users * Fix merge conflict * Minor clean up * Moved CSS to the application level * Started re-creating the data users tests * Adjusted test to use new HTML FORM keys * Bye byebug * Adjust the test for the new keys * Adjust the test for the new HTML FORM keys * Adjust test to new UI for data users * Added test for invalid data users entered * Removed commented lines --------- Co-authored-by: Kate Lynch <[email protected]> Co-authored-by: Robert-Anthony Lee-Faison <[email protected]> Co-authored-by: Hector Correa <[email protected]> Co-authored-by: Bess Sadler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got the Data Users section in the new and edit form to mimic the new design.
Closes #984
Empty table
Table with users
Modal to add new users
There are a few styling issues still pending that I documented on issue #1102