Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on aeson >= 2 #3

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

hololeap
Copy link

@hololeap hololeap commented Dec 8, 2022

Also, a couple doctests had output that differed from what was expected.

Modern aeson uses a new Key type

Signed-off-by: hololeap <[email protected]>
@hololeap hololeap marked this pull request as ready for review December 8, 2022 03:20
This reverts commit 4390e2e.

Signed-off-by: hololeap <[email protected]>
@hololeap hololeap marked this pull request as draft December 8, 2022 09:25
Switch to cabal-version 3.0, add "tested-with" section

Automatically format using cabal-fmt

Signed-off-by: hololeap <[email protected]>
@puffnfresh
Copy link
Owner

Seems like MIN_VERSION_aeson must not be defined, for some reason:

Error:      error: missing binary operator before token "("

Why could that be?

@hololeap
Copy link
Author

That's what I've been trying to figure out. These tests seem to work fine on my end.

@bmillwood
Copy link

See f2783c7 for an alternative that avoids use of CPP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants