Skip to content

Fixes, improvements, samples#117

Merged
seba-aln merged 4 commits intomasterfrom
fix/fixes-and-samples
Apr 1, 2025
Merged

Fixes, improvements, samples#117
seba-aln merged 4 commits intomasterfrom
fix/fixes-and-samples

Conversation

@seba-aln
Copy link

@seba-aln seba-aln commented Mar 28, 2025

fix: Added missing information in file publish endpoint

docs: Basic usage examples have been added

echo "PubNub Timetoken: " . $result->getTimetoken() . PHP_EOL;

// Calculate and display the Unix timestamp (seconds)
$unixTimestamp = floor($result->getTimetoken() / 10000000);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can 10000000 be extracted to constant with meaningful name?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess maybe but it's just an example. And even our docs don't name it in any way. it's jus 10M

@seba-aln
Copy link
Author

seba-aln commented Apr 1, 2025

@pubnub-release-bot release

@seba-aln seba-aln merged commit a7d0f51 into master Apr 1, 2025
8 checks passed
@seba-aln seba-aln deleted the fix/fixes-and-samples branch April 1, 2025 13:30
@pubnub-release-bot
Copy link
Contributor

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants