Merged
Conversation
marcin-cebo
reviewed
Jan 2, 2025
|
|
||
| protected const DELETE_PATH = "/v1/message-actions/%s/channel/%s/message/%s/action/%s"; | ||
| protected string $channel; | ||
| protected int | float $messageTimetoken; |
Contributor
There was a problem hiding this comment.
Why float is used here?
In other operations like AddMessageAction or GeMessageAction there is no float for timetokens definitions.
Author
There was a problem hiding this comment.
int or float is compatible with PNMessageAction DTO class
Contributor
There was a problem hiding this comment.
Is float needed in PNMessageAction DTO class?
What value it brings?
Author
There was a problem hiding this comment.
it is carried from publish response where it's cast to float. int is also valid hence the union type. it is later cast to string to concat with other requests value
seba-aln
force-pushed
the
feat/add-support-for-message-reactions
branch
from
b689e5d to
87962c5
Compare
marcin-cebo
approved these changes
Jan 2, 2025
Author
|
@pubnub-release-bot release |
pubnub-release-bot
requested review from
kazydek and
techwritermat
as code owners
kazydek
approved these changes
Jan 2, 2025
Contributor
|
🚀 Release successfully completed 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Support for adding, getting and deleting message reactions