hereNow with limit, offset, deprecated gcm, apns and removed mpns push notification gateway type#264
hereNow with limit, offset, deprecated gcm, apns and removed mpns push notification gateway type#264mohitpubnub merged 16 commits intomasterfrom
Conversation
mohitpubnub
requested review from
Xavrax,
jakub-grzesiowski and
marcin-cebo
as code owners
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
…0, offset = 0 (omitted when not provided explicitly by user)
…rted and decosmmisioned
| } | ||
| else if (pushType == PNPushType.MPNS) | ||
| { | ||
| Dictionary<string, object> pnMpns = BuildMpnsPayload(pushType); |
There was a problem hiding this comment.
Are you going to allow "fcm" as value for query param called "type" in all API calls related to PushNotificaiton?
There was a problem hiding this comment.
yes, it's accepted by server.
mohitpubnub
changed the title
dependency upgrade for test projects
jakub-grzesiowski
left a comment
jakub-grzesiowski
left a comment
There was a problem hiding this comment.
Minor comments, apart from that LGTM!
| } | ||
|
|
||
| logger?.Info($"{GetType().Name} request finished with status code {returnValue.Status?.StatusCode}"); | ||
| logger?.Trace($"{GetType().Name} request finished with status code {returnValue.Status?.StatusCode}"); |
There was a problem hiding this comment.
I applied formatting this time. this file was not formatted.
Or May be IDE setting change!! I'll check it. 👍
| if (limit > 1000) | ||
| { | ||
| logger.Debug( | ||
| "Provided 'limit' value exceeds the maximum allowed (1000). The value has been capped to 1000."); |
There was a problem hiding this comment.
Will it be capped on server side or should there be an assignment here?
There was a problem hiding this comment.
We need to explicitly provide this parameter value always.
| _pubnub.Subscribe<object>().Channels(new[] { "c1" }).Execute(); | ||
|
|
||
| // Wait 5 seconds - expect at least 1 heartbeat (at 3s) | ||
| await Task.Delay(TimeSpan.FromSeconds(5)); |
There was a problem hiding this comment.
Not an issue but interesting how it's TimeSpan.FromSeconds(5) instead of just 5000, I'm assuming an AI quirk? 😅
|
@pubnub-release-bot release as v8.0.0.0 |
|
🚀 Release successfully completed 🚀 |
5 participants
fix: deprecate gcm and re-map it to fcm
Discard use of gcm and replaced with fcm for push notification service type of google. Removed mpns support.
feat(presence): support for Limit and Offset parameters to the HereNow API.
BREAKING CHANGES: The HereNow method will return a maximum of 1000 occupants per channel. Previously, it was returning all occupants without limit parameter support. Use pagination through offset when more than 1000 occupants present in channel.
test: added new tests for duplicate subscribe requests.