Merged
Conversation
jakub-grzesiowski
requested review from
Xavrax,
marcin-cebo and
mohitpubnub
as code owners
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
mohitpubnub
approved these changes
Jul 29, 2025
| } | ||
| public string Event { get; internal set; } | ||
| public string Type { get; internal set; } | ||
| public string Event { get; internal set; } = ""; //values = set/delete for uuid/channel/UuidAssociation/ChannelAssociation |
|
|
||
| public long Timetoken { get; internal set; } | ||
| public object UserMetadata { get; internal set; } | ||
| public Dictionary<string, object> UserMetadata { get; internal set; } |
| Assert.IsNotNull(eventResult.MembershipMetadata, "eventResult.MembershipMetadata should not be null"); | ||
| Assert.AreEqual(eventResult.MembershipMetadata.Channel, channelMetadataId, "Wrong Channel ID in object event result"); | ||
| Assert.AreEqual(eventResult.MembershipMetadata.Uuid, uuidMetadataId, "Wrong User ID in object event result"); | ||
| Assert.AreEqual(eventResult.MembershipMetadata.Status, "active", "Wrong Status in object event result"); |
Contributor
Author
|
@pubnub-release-bot release as v7.4.1.0 |
Contributor
|
🚀 Release successfully completed 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: added MembershipMetadata container to PNObjectEventResult
Added MembershipMetadata container inside PNObjectEventResult to correctly parse and forward data when object event type is "membership"
fix: changed UserMetadata from object to Dictionary<string, object>
Fixed issue where some result objects like PNMessageResult had UserMetadata declared as an object instead of the standard Dictionary<string, object> format for metadata