fix/heartbet call on subscription change#251
Merged
mohitpubnub merged 12 commits intomasterfrom May 22, 2025
Merged
Conversation
added 2 commits
May 15, 2025 13:33
…eature tests, Added tests to ensure subscription with EE, join events emitted through heartbeat calls
mohitpubnub
requested review from
Xavrax,
jakub-grzesiowski and
marcin-cebo
as code owners
added 2 commits
May 15, 2025 19:25
jakub-grzesiowski
requested changes
May 15, 2025
Contributor
jakub-grzesiowski
left a comment
jakub-grzesiowski
left a comment
There was a problem hiding this comment.
Some minor comments
added 2 commits
May 16, 2025 06:29
test refactoring for heartbeat calls on subscribe()
Contributor
Author
|
@pubnub-release-bot release as v7.3.11.0 |
… removing non essential test setup. clean test code for event engine presence test.
Contributor
|
🚀 Release successfully completed 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: missing
heartbeatandleaveREST API calls when the event engine is enabled andpresenceTimeoutorpresenceHeartbeatIntervalnot set.Fix missing
heartbeatandleaveREST API calls when the event engine is enabled andpresenceTimeoutorpresenceHeartbeatIntervalnot set.