Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config.yml #11131

Merged
merged 1 commit into from
May 20, 2022
Merged

Update config.yml #11131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ firstPRMergeComment: |
<p>People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 </p>
<p>Read about <a href="https://github.com/publiclab/plots2/issues/3458">how to help support another newcomer here</a>, or find <a href="https://github.com/publiclab/plots2/labels/support">other ways to offer mutual support here</a>.</p>
</details>
<p>Join our Gitter channel <a href="https://gitter.im/publiclab/publiclab">here</a> to connect with other contributors</p> :inbox_tray:

<br />
You can also join our [Gitter channel](https://gitter.im/publiclab/publiclab) to connect with other contributors :inbox_tray:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh looks like the Github config file doesn't allow this syntax for links. Can you change line 42 to this?

 You can also join our <a href="https://gitter.im/publiclab/publiclab">Gitter channel</a> to connect with other contributors :inbox_tray:

You can open up a follow-up PR for that if you're interested. Thanks!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also remove line 41(<br />). Thanks!!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @TildaDares for helping to debug this ❤️

I'm curious though as to why the markdown syntax failed to work for lines 41 - 42.

In the same file (on lines 21 - 22), we have roughly the same syntax: a line break followed by the regular markdown syntax for links, and it's displaying just fine 🤔

Do you have any idea why it seems to work for some lines and not for others? Thank you!


# It is recommended to include as many gifs and emojis as possible