Issue Resolved: Fix Breaking-link Punctuation at end of URL in Comments #10947 #11048
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## main #11048 +/- ##
==========================================
- Coverage 82.45% 82.33% -0.12%
==========================================
Files 98 98
Lines 5990 5990
==========================================
- Hits 4939 4932 -7
- Misses 1051 1058 +7
|
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
@rajvidg These changes are not needed for the issue you're resolving. |
Actually there are four changes and the last two are were the required ones. @TildaDares |
README.md
Outdated
| @@ -1,5 +1,6 @@ | |||
| PublicLab.org | |||
| ====== | |||
| I forked and cloned this repo. | |||
There was a problem hiding this comment.
@rajvidg Can you remove this file from the PR? Thanks!!
There was a problem hiding this comment.
@rajvidg Can you remove this file from the PR? Thanks!!
Yes I am trying to, watching some tutorials. :'(
There was a problem hiding this comment.
@rajvidg Can you remove this file from the PR? Thanks!!
I removed the changes and reverted the file to its original one, but it got created as another commit, but the files changes section contains the required files, I tried doing it using git commands but the README file was not showing up in the branch where I committed rest of the changes, can you please look into it. @TildaDares
There was a problem hiding this comment.
@rajvidg You've resolved the issue 🎉
There was a problem hiding this comment.
@rajvidg You've resolved the issue 🎉
Oh! thank you @TildaDares :))
|
Code Climate has analyzed commit 96eae96 and detected 0 issues on this pull request. View more on Code Climate. |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
@rajvidg Can you add the issue number to the description above? Thanks!! |
Ya sure!! |
|
Also can you change the PR title to one that is more descriptive of the issue you're resolving? |
Okay |
rajvidg
changed the title
|
The issue was: Fix Breaking-link Punctuation at end of URL in Comments, with the tag: #10947 @TildaDares |
Thank you for giving me the chance :)) @TildaDares |
|
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. You can also join our Gitter channel to connect with other contributors 📥 |
|
Thanks, everyone!! |
|
@TildaDares would you mind checking this in https://stable.publiclab.org once it publishes? Thank you!! |
The commits made on 9th April, about updating two files are the required changes.