Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed conditional from notes tab on question page #10927

Merged
merged 1 commit into from
Apr 7, 2022
Merged

removed conditional from notes tab on question page #10927

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 10 additions & 20 deletions app/views/tag/show/_nav_tabs.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,15 @@
<ul class="nav nav-tabs" aria-labelledby="dropdownMenuButton">

<% if params[:action] == "show" || params[:action] == "comments"%>
<% unless params[:id].match("question:") %>
<li class="nav-item">
<a class="nav-link <% if @node_type == "note" %> active<% end %>" href="/tag/<%= params[:id] %>">
<i class="fa fa-file"></i>
<span class="d-lg-inline">
<span class="d-none d-md-inline"><%= t('tag.show.research_notes') %></span>
<span class="d-none d-sm-inline badge badge-primary"><%= params[:counts][:posts] %></span>
</span>
</a>
</li>
<% end %>
<li class="nav-item">
<a class="nav-link <% if @node_type == "note" %> active<% end %>" href="/tag/<%= params[:id] %>">
<i class="fa fa-file"></i>
<span class="d-lg-inline">
<span class="d-none d-md-inline"><%= t('tag.show.research_notes') %></span>
<span class="d-none d-sm-inline badge badge-primary"><%= params[:counts][:posts] %></span>
</span>
</a>
</li>
<li class="nav-item">
<a class="nav-link <% if @node_type == "questions" %> active<% end %>" href="/questions/tag/<%= params[:id] %>">
<i class="fa fa-question-circle"></i>
Expand Down Expand Up @@ -40,15 +38,7 @@
</li>
-->
<% if !@wildcard %>
<li class="nav-item">
<a class="nav-link <% if @node_type == "contributors" %> active <% end %>" href="/contributors/<%= params[:id] %>">
<i class="fa fa-user"></i>
<span class="d-lg-inline">
<span class="d-none d-lg-inline"><%= raw t('tag.show.people') %></span>
<span class="d-none d-sm-inline badge badge-primary"><%= @contributor_count %></span>
</span>
</a>
</li>

<% else %>
<a class="disabled" class="nav-item<% if @node_type == "contributors" %> active <% end %>" href="#" rel="tooltip" title="Contributors cannot be listed for wildcard tag searches" >
<i class="fa fa-user"></i>
Expand Down