forked from jywarren/image-sequencer
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image docs links fixed #1717
Open
ashirbad29
wants to merge
7
commits into
publiclab:main
Choose a base branch
from
ashirbad29:ashirbad29-load-image-docs-link
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
image docs links fixed #1717
ashirbad29
wants to merge
7
commits into
publiclab:main
from
ashirbad29:ashirbad29-load-image-docs-link
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add the condition to render the docs link as required
Thanks for opening this pull request! |
Codecov Report
@@ Coverage Diff @@
## main #1717 +/- ##
==========================================
- Coverage 66.67% 65.46% -1.22%
==========================================
Files 130 133 +3
Lines 2686 2748 +62
Branches 433 440 +7
==========================================
+ Hits 1791 1799 +8
- Misses 895 949 +54
|
please review my PR |
harshkhandeparkar
approved these changes
Oct 1, 2020
@blurry-x-face is my PR ready to merge? |
UI tests need update, try running tests locally to track down which test is failing |
@blurry-x-face can you please label it as hacktoberfest-accepted, :) |
/rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1525
npm run test-all
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!