Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image docs links fixed #1717

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

image docs links fixed #1717

wants to merge 7 commits into from

Conversation

ashirbad29
Copy link

@ashirbad29 ashirbad29 commented Oct 1, 2020

Fixes #1525

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm run test-all
  • code is in a uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@welcome
Copy link

welcome bot commented Oct 1, 2020

Thanks for opening this pull request!
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@gitpod-io
Copy link

gitpod-io bot commented Oct 1, 2020

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #1717 into main will decrease coverage by 1.21%.
The diff coverage is 47.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1717      +/-   ##
==========================================
- Coverage   66.67%   65.46%   -1.22%     
==========================================
  Files         130      133       +3     
  Lines        2686     2748      +62     
  Branches      433      440       +7     
==========================================
+ Hits         1791     1799       +8     
- Misses        895      949      +54     
Impacted Files Coverage Δ
examples/lib/defaultHtmlStepUi.js 11.35% <0.00%> (ø)
src/Modules.js 100.00% <ø> (ø)
src/modules/EdgeDetect/Module.js 100.00% <ø> (ø)
src/modules/WebglDistort/Module.js 2.29% <0.00%> (ø)
src/modules/ColorHalftone/Module.js 3.63% <3.63%> (ø)
src/modules/Overlay/Module.js 93.18% <94.11%> (-1.69%) ⬇️
src/modules/ColorHalftone/index.js 100.00% <100.00%> (ø)
src/modules/Colorbar/Module.js 100.00% <100.00%> (ø)
src/modules/Crop/Module.js 88.88% <100.00%> (ø)
src/modules/EdgeDetect/EdgeUtils.js 86.81% <100.00%> (-0.15%) ⬇️
... and 5 more

@ashirbad29
Copy link
Author

ashirbad29 commented Oct 1, 2020

please review my PR

@ashirbad29
Copy link
Author

@blurry-x-face is my PR ready to merge?

@rishabhshuklax
Copy link
Member

rishabhshuklax commented Oct 4, 2020

UI tests need update, try running tests locally to track down which test is failing

@ashirbad29
Copy link
Author

@blurry-x-face can you please label it as hacktoberfest-accepted, :)

@harshkhandeparkar harshkhandeparkar requested a review from a team as a code owner October 15, 2020 19:57
@jywarren
Copy link
Member

/rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load Image Docs Link Should Not Be Displayed (as it doesn't exist)
4 participants