-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github action to publish demo at sequencer.publiclab.org #1703
base: main
Are you sure you want to change the base?
Conversation
Try setting up github action to publish demo, following @harshithpabbati's work in https://github.com/harshithpabbati/image-sequencer/blob/main/.github/workflows/upstream.yml
How does this look? So to trigger it we publish a release on GitHub. We could alternatively try to trigger it on when the version number is incremented in the |
Codecov Report
@@ Coverage Diff @@
## main #1703 +/- ##
==========================================
- Coverage 66.67% 64.88% -1.80%
==========================================
Files 130 135 +5
Lines 2686 2828 +142
Branches 433 458 +25
==========================================
+ Hits 1791 1835 +44
- Misses 895 993 +98
|
Noting this really cool script by @sagarpreet-chadha that generates a release -- https://github.com/publiclab/plots2/releases/tag/v4.0 Quoting myself from the chatroom --
|
OK! So, shall we refactor this to use the Bash script from #1739? |
yes! |
@publiclab/is-maintainers Let's focus on this one next. |
I pushed something but I don't know if it is correct. @harshithpabbati ? |
- uses: actions/checkout@v2 | ||
- name: Merge upstream | ||
run: | | ||
git config --global user.name 'jywarren' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do/is it required @jywarren?
@@ -0,0 +1,16 @@ | |||
name: Publish sequencer.publiclab.org demo | |||
|
|||
on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also add manual triggers. We can use the workflow_dispatch
event.
Ref https://github.blog/changelog/2020-07-06-github-actions-manual-triggers-with-workflow_dispatch/
https://docs.github.com/en/actions/reference/events-that-trigger-workflows#workflow_dispatch
oh great, that's a good idea!
https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow
…On Thu, Mar 18, 2021 at 8:32 AM Barun Acharya ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/workflows/republish.yml
<#1703 (comment)>
:
> @@ -0,0 +1,16 @@
+name: Publish sequencer.publiclab.org demo
+
+on:
We should also add manual triggers. We can use the workflow_dispatch
event.
Ref
https://github.blog/changelog/2020-07-06-github-actions-manual-triggers-with-workflow_dispatch/
https://docs.github.com/en/actions/reference/events-that-trigger-workflows#workflow_dispatch
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1703 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAF6J2R7AFXBCPXWMY4WPLTEHXFRANCNFSM4PT6OWXQ>
.
|
Try setting up github action to publish demo, following @harshithpabbati's work in https://github.com/harshithpabbati/image-sequencer/blob/main/.github/workflows/upstream.yml
Re: #1692