Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the z-index of .wk-prompt to resolve the problem of map credits being overlayed on Insert Image popup. #707

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Priyaraj17
Copy link

@Priyaraj17 Priyaraj17 commented Apr 5, 2021

…ts being overlayed on Insert Image popup.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt jasmine
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!
image

Issue: #9442

@gitpod-io
Copy link

gitpod-io bot commented Apr 5, 2021

@cesswairimu
Copy link
Collaborator

Weird that the tests are failing here, I will close and reopen. Thanks @Priyaraj17

@cesswairimu cesswairimu closed this Apr 8, 2021
@cesswairimu cesswairimu reopened this Apr 8, 2021
@gitpod-io
Copy link

gitpod-io bot commented Apr 8, 2021

@Priyaraj17
Copy link
Author

Shall I make another PR?

@cesswairimu
Copy link
Collaborator

no @Priyaraj17, lets try and debug here, thanks

@Priyaraj17
Copy link
Author

Okay sure.

@cesswairimu
Copy link
Collaborator

cesswairimu commented Apr 8, 2021

@Priyaraj17 looks like this test has been failing on a number of PRs for a while now...I will check if there is an issue for that and open one if not. The test needs to be fixed on a different PR and after that your tests should be passing

@cesswairimu
Copy link
Collaborator

Found the issue opened here #683

@Priyaraj17
Copy link
Author

@cesswairimu okay thank you so much. I will also take a look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants