Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made responsive for mobile screens #673

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Charu271
Copy link

@Charu271 Charu271 commented Dec 30, 2020

issue: #526
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt jasmine
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@welcome
Copy link

welcome bot commented Dec 30, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Please make sure you've bumped up the version number in the repository's package.json file and that you've incorporated your changes in the /dist/ sub-directory.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@gitpod-io
Copy link

gitpod-io bot commented Dec 30, 2020

@NitinBhasneria
Copy link
Collaborator

@Charu271 please add the screenshots of the changes you have made. To be precise you should add before and after the changes screenshot. Also, always point to the issue you have made this pull request.

@Charu271
Copy link
Author

image

image

image

image

image

image

image

image

Above are the screenshots in mobile view. It refers to issue #526
Sorry I haven't took the screenshots before changes

@NitinBhasneria
Copy link
Collaborator

Changes look good. @jywarren @Sagarpreet @cesswairimu have a look.

@cesswairimu
Copy link
Collaborator

cesswairimu commented Jan 6, 2021

oh wow!! these look awesome 🚀 ..fantastic job @Charu271, could you please do a rebase,...also I will request @sagarpreet-chadha for review here. Thanks a lot for working on this 🎉 🎉

Copy link
Contributor

@Sagarpreet Sagarpreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉

<script src="../node_modules/at.js/dist/js/jquery.atwho.min.js"></script>
<script src="data/emoji.js"></script>
</head>

<body>
<div class="pl-editor">
<div class="pl-editor container-fluid">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

container-fluid 🎉

@Charu271
Copy link
Author

Charu271 commented Jan 6, 2021

Thank you @NitinBhasneria @cesswairimu @Sagarpreet .
@cesswairimu Do I need rebase my branch?

@cesswairimu
Copy link
Collaborator

@Charu271 yes please...after that we are good to merge. Thanks

@Charu271
Copy link
Author

Charu271 commented Jan 7, 2021

@cesswairimu I rebased my branch but its showing already up to date

@cesswairimu
Copy link
Collaborator

cesswairimu commented Jan 7, 2021

Oh so sorry, my bad 🤦...thought we were at plots2..please ignore my comment

@Charu271
Copy link
Author

Charu271 commented Jan 7, 2021

No issues @cesswairimu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants