-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
made responsive for mobile screens #673
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
@Charu271 please add the screenshots of the changes you have made. To be precise you should add before and after the changes screenshot. Also, always point to the issue you have made this pull request. |
Above are the screenshots in mobile view. It refers to issue #526 |
Changes look good. @jywarren @Sagarpreet @cesswairimu have a look. |
oh wow!! these look awesome 🚀 ..fantastic job @Charu271, could you please do a rebase,...also I will request @sagarpreet-chadha for review here. Thanks a lot for working on this 🎉 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🎉
<script src="../node_modules/at.js/dist/js/jquery.atwho.min.js"></script> | ||
<script src="data/emoji.js"></script> | ||
</head> | ||
|
||
<body> | ||
<div class="pl-editor"> | ||
<div class="pl-editor container-fluid"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
container-fluid
🎉
Thank you @NitinBhasneria @cesswairimu @Sagarpreet . |
@Charu271 yes please...after that we are good to merge. Thanks |
@cesswairimu I rebased my branch but its showing already up to date |
Oh so sorry, my bad 🤦...thought we were at plots2..please ignore my comment |
No issues @cesswairimu |
issue: #526
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt jasmine
fixes #0000
-style reference to original issue #@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!