Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust CSS styling of rich text toolbar to Bootstrap 4 for consistency #664

Open
jywarren opened this issue Dec 5, 2020 · 24 comments · May be fixed by #705
Open

Adjust CSS styling of rich text toolbar to Bootstrap 4 for consistency #664

jywarren opened this issue Dec 5, 2020 · 24 comments · May be fixed by #705
Assignees

Comments

@jywarren
Copy link
Member

jywarren commented Dec 5, 2020

I think the lines of code could be somewhere around here?

$(".wk-switchboard button").addClass("btn-sm");

image

See how the buttons here don't match -- i think the basic buttons are via woofmark but the black-outlined ones are the ones we've added programmatically after woofmark is loaded. We'd love help with this, it probably will take some trial and error but isn't such a complex change!

Originally posted by @jywarren in #663 (comment) (cc @keshav234156, noting I've split this out!)

@eynglv
Copy link

eynglv commented Jan 30, 2021

@jywarren hi, could i take this bug? would be my first open source contribution

are you looking to change the outline (make all the buttons outlined) or you want them to be basic (via woofmark)?

@devan5hu
Copy link

devan5hu commented Feb 10, 2021

@jywarren Hello! I am fairly new to contributing to major repositories on Github in-fact this is my very first comment. I started working on this issue today and found out the fix for it. Just wanted to share a picture of the result before I created a new branch. The changes were very minor and I want to know if its correct!
Buttonfix

I also fixed the Custom Insert button in responsive view.
Buttonfixresponsive

Please correct me if I am wrong and you expected something else!

@Goodiec
Copy link

Goodiec commented Oct 8, 2021

Hi, @jywarren, I'm Goodness, an Outreachy applicant interested in contributing to the "Refine the Public Lab Rich Editor" project. I would like to if this issue is still open and if I can work on it.

@jywarren
Copy link
Member Author

Hi @Goodiec we'd love a contribution here. I wonder if #705 already gets at part of it? However i wonder if it could be done more efficiently in a single CSS selector instead of individually for each.

I'm also not sure if this recent tweak I made may have resolved the issue as well?

b1cb346

But, if you can try it out locally with the latest code to confirm, we should be able to close this issue one way or another. Thank you!!!

@Goodiec
Copy link

Goodiec commented Oct 12, 2021

Hi @Goodiec we'd love a contribution here. I wonder if #705 already gets at part of it? However i wonder if it could be done more efficiently in a single CSS selector instead of individually for each.

I'm also not sure if this recent tweak I made may have resolved the issue as well?

b1cb346

But, if you can try it out locally with the latest code to confirm, we should be able to close this issue one way or another. Thank you!!!

Sure, I'll try that. Thank you!

@RaviAnand111
Copy link
Contributor

hey @jywarren @TildaDares @NARUDESIGNS, can I work on this issue ?

@TildaDares
Copy link
Member

@RaviAnand111 I think this issue has been resolved. I checked on my local environment and all of the buttons match.

@TildaDares
Copy link
Member

Thanks @RaviAnand111! I think we can close this issue now.

@RaviAnand111
Copy link
Contributor

Hey @TildaDares, I checked my local environment and all the buttons do not match,
image
Do you know why is this happening?

@TildaDares
Copy link
Member

@RaviAnand111 Have you pulled changes from this repo recently?

@RaviAnand111
Copy link
Contributor

yes I did, git status, says uptodate see
image

@RaviAnand111
Copy link
Contributor

see this the result of git pull upstream main
image

@TildaDares
Copy link
Member

@RaviAnand111 I can see what you see now. I just updated my local repo.

@TildaDares TildaDares reopened this Jan 3, 2022
@RaviAnand111
Copy link
Contributor

No, I didn't, Should I do it right now ?

@TildaDares
Copy link
Member

I've just assigned you @RaviAnand111

@RaviAnand111
Copy link
Contributor

Thanks @TildaDares ,
I just had this 1 doubt, should I create a different branch every time I work on different issue or should I work in the main branch ?

@TildaDares
Copy link
Member

@RaviAnand111 It's better to create a different branch when you work on different issues so that you can isolate your changes from your main branch.

@RaviAnand111
Copy link
Contributor

ok, now I understand, ThankYou for explaining, you are like an elder sister who helps me whenever I am in trouble,
ThankYou

@NARUDESIGNS
Copy link
Collaborator

ok, now I understand, ThankYou for explaining, you are like an elder sister who helps me whenever I am in trouble, ThankYou

Lol yeah, she's amazing. In my case, she'd always help me with very useful resources.
You are doing a great job as well my friend @RaviAnand111

@RaviAnand111
Copy link
Contributor

Thanks alot, @NARUDESIGNS, it is really a complement, getting thumps up from you guys. ❤️

@RaviAnand111
Copy link
Contributor

Does this look good ? @TildaDares @NARUDESIGNS

image

@RaviAnand111
Copy link
Contributor

Closer look

image

@NARUDESIGNS
Copy link
Collaborator

NARUDESIGNS commented Jan 4, 2022

@RaviAnand111 I think someone might have worked on this before. Here - #705
This is a very good job by the way!

@RaviAnand111
Copy link
Contributor

yeah, #705 has already solved it, so should I leave it and work on some other issue ?,
yeah, sure you can tell me about UI changes if you want.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants