Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content interferes with toolbar functions in editor #9441

Closed
waridrox opened this issue Apr 4, 2021 · 12 comments · Fixed by publiclab/PublicLab.Editor#710
Closed

Content interferes with toolbar functions in editor #9441

waridrox opened this issue Apr 4, 2021 · 12 comments · Fixed by publiclab/PublicLab.Editor#710
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed

Comments

@waridrox
Copy link
Member

waridrox commented Apr 4, 2021

Please describe the problem (or idea)

What happened just before the problem occurred? Or what problem could this idea solve?

The writeup content of the post gets mixed up with the editor toolbar when scrolling or viewing content in general while making a post.

FC586C05-ABF2-4D59-A9CB-1655D4D4A9DA_1_201_a

Please show us where to look

https://publiclab.org/

What's your PublicLab.org username?

waridrox

Browser, version, and operating system

Chrome v89

Possible solution could be to hide the transparency of the buttons and make them like the first half of the toolbar section so as to maintain the consistency.

Steps to reproduce the error

Here's how one can reproduce the error -

  1. Click on share your work button to create a new post.
  2. Move to content section and add a few paragraphs.
  3. Scroll the page by placing the cursor outside the content section.
  4. Witness the error
overlay.mp4
@waridrox waridrox added the bug the issue is regarding one of our programs which faces problems when a certain task is executed label Apr 4, 2021
@waridrox waridrox changed the title Content mixes with toolbar functions in editor Content interferes with toolbar functions in editor Apr 4, 2021
@waridrox
Copy link
Member Author

waridrox commented Apr 5, 2021

Interestingly, I'm not able to reproduce the bug locally 🤔 Can someone pls confirm -

local.mp4

@TildaDares
Copy link
Member

Can I work on this?

@waridrox
Copy link
Member Author

waridrox commented Apr 7, 2021

@TildaDares sure 😄, go for it! 🚀

@TildaDares
Copy link
Member

@waridox I was able to reproduce the error locally. I think a possible fix would be to make these buttons have an opaque background.

Before

Screenshot 2021-04-08 at 15 34 31

After

Screenshot 2021-04-08 at 15 38 04

What do you think?

@waridrox
Copy link
Member Author

waridrox commented Apr 8, 2021

Yes, @TildaDares you're thinking in the right direction! We don't require transparency on those buttons with the content.

@eightballocto
Copy link
Contributor

This can be accomplished by adding this rule:

.btn-light {
    background-color: white;
}

However, it should be noted that the Tags button is lacking the .btn-light class for whatever reason so more investigation is required.

@TildaDares
Copy link
Member

@eightballocto The Toolbar already has a btn-light class but btn-outline-secondary is overriding it. Also I can't find this page in my local environment, can you please show me where it is?

@TildaDares
Copy link
Member

Just to be sure these are the tags you're referring to.

image

@eightballocto
Copy link
Contributor

eightballocto commented Apr 8, 2021

@eightballocto The Toolbar already has a btn-light class but btn-outline-secondary is overriding it. Also I can't find this page in my local environment, can you please show me where it is?

image
using Inspect Element in my developer environment. It seems like these buttons are dynamically generated or from elsewhere. The "Tags" button I was referring to is in the toolbar, not the text field.

Edit/Addendum: I was also unable to find these elements in my local environment, hence my suspicion of it being in a separate repository or dynamically generated (which wouldn't make much sense, if you ask me)

@waridrox
Copy link
Member Author

waridrox commented Apr 8, 2021

Hi all, @eightballocto is right and there's a different repository https://github.com/publiclab/PublicLab.Editor dedicated to the editor functionality and I recommend to take a look at publiclab/PublicLab.Editor#664 to anyone who is trying to come up with the fix. Thanks :)

@TildaDares
Copy link
Member

@waridox How do I link this issue to my PR?

@Priyaraj17
Copy link
Contributor

Hey, you just need to add the issue number in the PR template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants