Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trailer encoding #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bouk
Copy link
Contributor

@bouk bouk commented Apr 19, 2023

I saw trailers encoded like b'grpc-status': b'0' which is happening because strings and bytes were being mixed. Now trailers are always strings and they're encoded in the pack_trailers method

@gitpushdashf
Copy link
Contributor

Looks good to me, but I don't know about any wider reaching implications of this.

@public
Copy link
Owner

public commented Apr 21, 2023

Thank you very much for the fix.

Any chance you can update the tests to cover this? e.g. unwrap_message_asgi is tested in test_protocol.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants