FIX type of SimplePeerConnectionHandlerOptions.webSocketConstructor #7311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@nero-networks this fails the CI, please check. |
Contributor
Author
|
i learned about the incompatibility of browser WebSockets and nodes WebSocket. npm run test runs the type checking correct now. Strangely it fails because "test:browser" is missing in package.json scripts. |
nero-networks
force-pushed
the
bugfix/webrtc-type-fix
branch
from
0de01a6 to
17d73a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
A fix of the typing of SimplePeerConnectionHandlerOptions.webSocketConstructor.
Describe the problem you have without this PR
Without this change the expected type is a WebSocket instance, not the constuctor.
Todos