Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/shmctl: refine command-line UI: SHMinit = init, reworded [options] #132

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

IepIweidieng
Copy link
Contributor

@IepIweidieng IepIweidieng commented Dec 17, 2023

  • shmctl SHMinit now no longer invokes resolve_garbage() (for pttcache) & resolve_fcache().
  • shmctl SHMinit is now identical to shmctl init and no longer requires uhash_loader to execute beforehand.
  • An invalid command also no longer requires uhash_loader to execute, so shmctl -h now always works.
  • The options of each shmctl command have been made more clarified.
  • The missing documenting of shmctl init has now been included.

See the commit messages for details.

* fix <invalid-command> failing without `uhash_loader` first
  by postponing SHM operations until necessary
    * main()
* make "SHMinit" & "init" treated the same
  so that SHMinit no longer requires uhash_loader
  but no longer resolve_garbage() (pttcache) & resolve_fcache()
    * add previously implicit command "init" into cmd[]
* rearrange codes into an early return pattern
    * main()
@IepIweidieng IepIweidieng changed the title util/shmctl: refine command-line UI: SHMinit = init, reworded [option]s util/shmctl: refine command-line UI: SHMinit = init, reworded [options] Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants