Fix for Issue #155 - URL links with non ASCII characters break. Removes ... #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...code from commit: 4851eda8aa78
If you see discussion from the issue itself, it was not easy to determine why this feature was designed as is. The current designed behavior would prevent users from properly inserting URL links into the chat window that contain special characters/non-ascii characters such as umlauts. At minimum if reverting the relevant commit to "fix" this issue is not recommended (due to what I assume is some kind of security concern) then the code should be modified to add additional domains; see issue #155 for specifics as to which domains to consider adding. If this latter course of action is recommend, please let me know, I'll be happy to do that instead of removing entirely the code in question.