Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New fields for identities #357

Merged
merged 10 commits into from
Dec 9, 2024
Merged

New fields for identities #357

merged 10 commits into from
Dec 9, 2024

Conversation

owl352
Copy link
Collaborator

@owl352 owl352 commented Dec 4, 2024 •
edited
Loading

Issue

For new identities page, we need additional data in response from API

Things done

  • Was added new method in DAPI.js, which allows to get identities public keys from dapi.
  • For this method, was updated my repo with dapi-client, because getIdentityKeys didn't support value all_keys for response_type.
  • Was updated request query to indexer DB.
  • Added fundingCoreTx from assetLockProof of identity create transaction for default identities
  • Updated the Identity model accordingly
  • For manual tests we had to find an identifier with contract bounds, so we managed to implement this field for decoding as well as for identity (https://testnet.platform-explorer.com/transaction/7D9D512FDF1AE4E37B964B2C62BB36A4A6D99609C6C2EB9E58A32D50E42C0082)
  • Updated README.md
  • Updated integration tests for new data

@owl352 owl352 added the backend Related to backend (API) label Dec 4, 2024
@owl352 owl352 self-assigned this Dec 4, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
platform-explorer-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 11:50am
platform-explorer-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 11:50am

pshenmic
pshenmic previously approved these changes Dec 9, 2024
View reviewed changes
@owl352
Merge branch 'develop' into feat/identities-fields
daf2c4f 
# Conflicts:
#	packages/api/src/dao/IdentitiesDAO.js
@owl352 owl352 marked this pull request as ready for review December 9, 2024 11:48
@owl352 owl352 merged commit e737427 into develop Dec 9, 2024
9 checks passed
@owl352 owl352 deleted the feat/identities-fields branch December 9, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshenmic pshenmic pshenmic approved these changes

Assignees

@owl352 owl352

Labels
backend Related to backend (API)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owl352 @pshenmic