Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create default SSLContext if CA bundle isn't present #6781

Closed
wants to merge 1 commit into from

Conversation

AdamWill
Copy link
Contributor

@AdamWill AdamWill commented Aug 1, 2024

Similar to e188799 , this also skips creation of the default SSLContext on FileNotFoundError, which is raised if DEFAULT_CA_BUNDLE_PATH does not exist.

See: https://bugzilla.redhat.com/show_bug.cgi?id=2297632

Similar to e188799 , this also
skips creation of the default SSLContext on FileNotFoundError,
which is raised if DEFAULT_CA_BUNDLE_PATH does not exist.

See: https://bugzilla.redhat.com/show_bug.cgi?id=2297632

Signed-off-by: Adam Williamson <[email protected]>
@nateprewitt
Copy link
Member

Hi @AdamWill, #6767 is likely the path forward at this point. We've found a number of sharp edges with the default caching behavior to a point it probably doesn't belong in Requests.

@AdamWill
Copy link
Contributor Author

AdamWill commented Aug 1, 2024

Ah, thanks, didn't see that one. I'll wait for it to be finalized then backport it. Thanks!

@AdamWill AdamWill closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants