Skip to content

ci: Run diff-shades on unstable instead of preview #4741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

ci: Run diff-shades on unstable instead of preview #4741

wants to merge 1 commit into from
+12 −12

Conversation

cobaltt7
Copy link
Collaborator

Description

This PR changes diff-shades to run on the stable and unstable styles as opposed to the stable and preview styles.

I opted to replace the preview job with the unstable job instead of adding a new job because all preview changes also exist in unstable so running both feels redundant, and it takes a long time to run so it wouldn't be worth it to have both jobs.

I wasn't sure if the "preview-changes" mode was meant to be interpreted as "Changes in the preview style" or "Preview new changes". I took it to mean the former and renamed it to unstable-style-changes for clarity, but I can change that if desired

Checklist - did you ...

  • [-] Implement any code style changes under the --preview style, following the
    stability policy?
  • [-] Add an entry in CHANGES.md if necessary?
  • [y] Add / update tests if necessary?
  • [y] Add new / update outdated documentation?

@cobaltt7 cobaltt7 requested a review from JelleZijlstra August 31, 2025 22:57
@cobaltt7 cobaltt7 added skip news Pull requests that don't need a changelog entry. C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases labels Aug 31, 2025
@cobaltt7
Copy link
Collaborator Author

cobaltt7 commented Sep 1, 2025

Seems like it's hanging and eventually timing out. Probably a bug with string_processing

@cobaltt7 cobaltt7 marked this pull request as draft September 1, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

Assignees
No one assigned
Labels
C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases skip news Pull requests that don't need a changelog entry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cobaltt7