Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't remove parenthesis around long dictionary values #4377

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

fix: Don't remove parenthesis around long dictionary values #4377

wants to merge 16 commits into from

Conversation

cobaltt7
Copy link
Contributor

@cobaltt7 cobaltt7 commented Jun 6, 2024 •
edited
Loading

Description

Resolves #4158 (string_processing and wrap_long_dict_values_in_parens)
Resolves #3452 (wrap_long_dict_values_in_parens)

Still need to move to the preview style & add changelog entry

Checklist - did you ...

  • [n] Add an entry in CHANGES.md if necessary?
  • [y] Add / update tests if necessary?
  • [-] Add new / update outdated documentation?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024 •
edited
Loading

diff-shades reports zero changes comparing this PR (9140aa2) to main (b677a64).

What is this? | Workflow run | diff-shades documentation

@cobaltt7 cobaltt7 changed the title fix(preview): Don't remove parenthesis around long dictionary values fix: Don't remove parenthesis around long dictionary values Jun 14, 2024
cobaltt7 added 13 commits November 8, 2024 16:54
@cobaltt7
add more tests
a54503d 
Signed-off-by: cobalt <[email protected]>
@cobaltt7
Merge branch 'main' into psfgh-4158
96634f4
@cobaltt7
make progress i think
6890753 
Signed-off-by: cobalt <[email protected]>
@cobaltt7
dont wrap simple assignments
7e80b09 
Signed-off-by: cobalt <[email protected]>
@cobaltt7
fix a few regressions
a13dcd7 
Signed-off-by: cobalt <[email protected]>
@cobaltt7
hmmm
71fed49 
Signed-off-by: cobalt <[email protected]>
@cobaltt7
oop
1fb452a 
Signed-off-by: cobalt <[email protected]>
@cobaltt7
no at this point it mostly works so go back here
4102ffe 
Signed-off-by: cobalt <[email protected]>
@cobaltt7
fix preview_long_strings
22a18b8 
Signed-off-by: cobalt <[email protected]>
@cobaltt7
maybe finish it!
d39e79d 
Signed-off-by: cobalt <[email protected]>
@cobaltt7
Merge branch 'main' into psfgh-4158
68618f8
@cobaltt7
fix tests
1dc7fa5 
Signed-off-by: cobalt <[email protected]>
@cobaltt7
Fix type error
daa9431 
Signed-off-by: cobalt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@cobaltt7