Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't hug parens if it would mean putting two # type: ignore comments on the same line #4037

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Don't hug parens if it would mean putting two # type: ignore comments on the same line #4037

wants to merge 10 commits into from
+122 −34

Commits on Nov 9, 2023

  1. Move comment related functions to comments.py and get rid of magic st… 

    …rings
    @henriholopainen
    henriholopainen committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    45a0e24 View commit details
    Browse the repository at this point in the history

  2. Add test case

    @henriholopainen
    henriholopainen committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    660112f View commit details
    Browse the repository at this point in the history

  3. Don't hug parens if type ignore on opening paren

    @henriholopainen
    henriholopainen committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    3a6a229 View commit details
    Browse the repository at this point in the history

  4. Add changelog line

    @henriholopainen
    henriholopainen committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    3a110f8 View commit details
    Browse the repository at this point in the history

  5. Update PR number

    @henriholopainen
    henriholopainen committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    9fb65c6 View commit details
    Browse the repository at this point in the history

  6. Fix typo

    @henriholopainen
    henriholopainen committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    f99d14a View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. Add test cases

    @henriholopainen
    henriholopainen committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    3d59d73 View commit details
    Browse the repository at this point in the history

  2. Make sure we don't combine two #type:ignore comments to one line

    @henriholopainen
    henriholopainen committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    2b22099 View commit details
    Browse the repository at this point in the history

  3. Add myself to contributors

    @henriholopainen
    henriholopainen committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    61bf523 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2023

  1. Merge branch 'main' into issue_4036

    @henriholopainen
    henriholopainen authored Nov 18, 2023
    Configuration menu
    Copy the full SHA
    3c87261 View commit details
    Browse the repository at this point in the history