Skip to content

Group community features in variants files #4831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
3d-gussner wants to merge 4 commits into
base: MK3
Choose a base branch
from
Open

Group community features in variants files #4831

3d-gussner wants to merge 4 commits into from
+828 −785

Conversation

@3d-gussner
Copy link
Collaborator

@3d-gussner 3d-gussner commented Jan 8, 2025 •
edited
Loading

All community features are now grouped at the end of the variant files.

  • White spaces in variant files removed
  • Added some comments to all #endif in variant files
  • MAX_OVERSHOOT_PID_AUTOTUNE only #define-d in variant files
  • Update Community made file

@github-actions
Copy link

github-actions bot commented Jan 8, 2025 •
edited
Loading

All values in bytes. Δ Delta to base

Target ΔFlash ΔSRAM Used Flash Used SRAM Free Flash Free SRAM
MK3S_MULTILANG 0 0 248160 5654 5792 2538
MK3_MULTILANG 0 0 247538 5663 6414 2529

sarusani
sarusani reviewed Jan 10, 2025
View reviewed changes
@3d-gussner 3d-gussner changed the title 🚧 WIP: Group community features in variants files Group community features in variants files Jan 10, 2025
@3d-gussner 3d-gussner marked this pull request as ready for review January 10, 2025 15:30
@3d-gussner 3d-gussner requested a review from sarusani January 13, 2025 05:27
@3d-gussner 3d-gussner requested a review from gudnimg February 11, 2025 05:05
@3d-gussner 3d-gussner requested a review from DRracer February 26, 2025 09:43
@3d-gussner 3d-gussner force-pushed the MK3_Community_features branch from 3a95750 to 1cc1108 Compare March 10, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarusani sarusani Awaiting requested review from sarusani

@gudnimg gudnimg Awaiting requested review from gudnimg

@DRracer DRracer Awaiting requested review from DRracer

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@3d-gussner @sarusani