Improve filament sensor PCB upgrade logic #3155
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure the upgrade logic only runs if the previous PCB version is unknown or if an upgrade is actually possible. - Ensure the check only runs until a reliable detection can be made, then stop checking. - Ensure the detection doesn't run forever: limit the number of total autodetection attempts until the next FW reset.
.. into temperature.* where the ADC conversion is currently performed. Fixes build on the MK3 variant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code surrounding the IR filament sensor board upgrade is problematic in a few ways. It still checks for a PCB upgrade even though the FW already knows the PCB is at the newest version, wasting cycles. It allows downgrading the version after a previous successful detection, which doesn't make much sense.
In this PR: