Revert/cleanup mininum extruder height during M600 #3121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change restores the minimum extruder height for filament purge during M600 from the current 50mm back to 27mm from FW 3.9. We do this by introducing a new option for unload_filament() to indicate that the unload is part of an automatic swap, and in such cases avoid raising more than absolutely necessary (this will _also_ come in handy to avoid the extra purge in PR prusa3d#2318 during M600). A new define MIN_Z_FOR_SWAP is introduced for this purpose. MIN_Z_FOR_UNLOAD is still used for manual lcd unload and for M702 and hasn't been changed.
gcode_M600_filament_change_z_shift is almost useless, since it performs what is already been done internally by filament_unload(). However it *does* cause the carriage to raise earlier during unload compared to making the user wait after "press for unload". Change it so the calculated Z height matches MIN_Z_FOR_SWAP.
DRracer
approved these changes
Apr 22, 2021
wavexx
added a commit
to wavexx/Prusa-Firmware
that referenced
this pull request
Jun 28, 2021
Swaps are triggered with a hot printer, and thus don't require to perform an extra purge. This follows my own advice from PR prusa3d#3121.
wavexx
added a commit
to wavexx/Prusa-Firmware
that referenced
this pull request
Mar 29, 2022
Swaps are triggered with a hot printer, and thus don't require to perform an extra purge. This follows my own advice from PR prusa3d#3121.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change restores the minimum extruder height for filament purge
during M600 from the current 50mm back to 27mm from FW 3.9.
We do this by introducing a new option for unload_filament() to indicate
that the unload is part of an automatic swap, and in such cases avoid
raising more than absolutely necessary (this will also come in handy
to avoid the extra purge in PR #2318 during M600).
A new define MIN_Z_FOR_SWAP is introduced for this purpose.
MIN_Z_FOR_UNLOAD is still used for manual lcd unload and for M702 and
hasn't been changed.
PFW-1237