Prevent heating after Stop() is called #2788
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks IsStopped() before heating If M104, M109, M140 or M190 is called, we don't set temperature, and sends "Hotend/Bed temperature not set because Stop() has been called. Use M999 to reset and try again." over serial. Removes menu items that cause heating if IsStopped(): Preheat Print from SD Load filament Unload filament Settings > Temperature
ghost
force-pushed
the
no-preheat-in-error
branch
2 times, most recently
from
84c73aa to
3db242b
Compare
awenelo
force-pushed
the
no-preheat-in-error
branch
from
931ea7b to
3db242b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check
IsStopped()before setting temperatures. This is an alternative to #2609 and fixes #2605.Additions:
Check
IsStopped()before heating, don't heat iftrueIf the Gcode M104, M109, M140 or M190 is called and
IsStopped()istrue, we don't set temperature, and sendHotend/Bed temperature not set because Stop() has been called. Use M999 to reset and try again.over serial.Don't show menu items that cause heating if
IsStopped()istrue