Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce on_create_child_context hook for creating non root contexts #67

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

unleashed
Copy link

This is based on previous work from @yskopets for creating child contexts via a hook in the root context (#6).

The patches first introduce the mechanism, then change the examples to make use of it, and finally remove the other currently existing methods in a breaking change to both simplify usage by having a single way to do this and clean up some of the code which should no longer be necessary. Compile-tested all examples after every patch.

Feel free to use or cherry pick partially or as needed.

…ontexts

This introduces a new hook that is called when a new child context is
created from a root context. The implementer can construct and specify the
type of the new context with a single hook method.

This patch is based on work by Yaroslav Skopets <[email protected]>.

Signed-off-by: Alejandro Martinez Ruiz <[email protected]>
…oot ctxts

Having two ways to create non root contexts before introducing
on_create_child_context can cause confusion. This new method is simple
and should cover the usages of the other two in a cleaner way, so let's
remove the others in this _breaking_ change.

Signed-off-by: Alejandro Martinez Ruiz <[email protected]>
@google-cla
Copy link

google-cla bot commented Dec 23, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@unleashed
Copy link
Author

@googlebot I signed it!

@PiotrSikora
Copy link
Member

Hi @unleashed! Sorry, I've missed the email notifications for your PRs.

Is this only a "style rewrite" of what was already implemented in #34, or am I missing something? In any case, while I agree that this is a nicer interface, the next version of the ABI is most likely going to remove generic context type, and plugins will be able to support multiple extensions points (e.g. both HTTP and TCP), so we're going to need typed constructors, which this PR removes.

@unleashed
Copy link
Author

Yes, this is a rewrite of #34 with a better user development experience and slightly nicer internal structure.

So if we'll need typed constructors anyway it's not worth it to merge this, but I'd like to take a look and see how we could improve on the current interface while allowing the incoming changes. Do you have a link to these changes and/or to a place where the ABI evolution is being discussed?

mathetake added a commit to tetratelabs/proxy-wasm-go-sdk that referenced this pull request Mar 9, 2021
This is kind of an improvement from #93 in favor of proxy-wasm/proxy-wasm-rust-sdk#34 and proxy-wasm/proxy-wasm-rust-sdk#67

Note that this is a breaking change, though the fix is trivial.

Signed-off-by: Takeshi Yoneda [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants