Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tags): handle AWS dictionary type tags #4656

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

MrCloudSec
Copy link
Member

@MrCloudSec MrCloudSec commented Aug 6, 2024

Context

Fix #4655

Description

Handle AWS dictionary type tags in unroll_tags function.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested review from a team as code owners August 6, 2024 19:51
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.08%. Comparing base (8aca456) to head (2049914).
Report is 526 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4656   +/-   ##
=======================================
  Coverage   89.07%   89.08%           
=======================================
  Files         910      910           
  Lines       27739    27741    +2     
=======================================
+ Hits        24709    24713    +4     
+ Misses       3030     3028    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!!

@jfagoagas jfagoagas merged commit 89c6652 into master Aug 7, 2024
11 checks passed
@jfagoagas jfagoagas deleted the PRWLR-4416-solve-key-error-in-handling-tags branch August 7, 2024 06:34
github-actions bot pushed a commit that referenced this pull request Aug 7, 2024
@github-actions github-actions bot added the was-backported The PR was successfully backported to the target branch label Aug 7, 2024
Copy link
Contributor

github-actions bot commented Aug 7, 2024

💚 All backports created successfully

Status Branch Result
v4.3

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
was-backported The PR was successfully backported to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No file output despite successful aws scan
2 participants