Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --tile-compression on convert operations. #188

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lseelenbinder
Copy link

This adds the first step towards supporting additional tile compressions in the convert tool.

If a tile-compression flag is passed, then any compression other than gzip is passed-through as-is, assumed to be valid. Also sets the header compression flag as expected.

@bdon
Copy link
Member

bdon commented Oct 21, 2024

Is the goal here to convert MBTiles that use non-gzip compression, or to produce archives that use non-gzip compression?

The MBTiles spec is underspecified here (https://github.com/mapbox/mbtiles-spec/blob/master/1.3/spec.md#future-directions) and I don't know of any open source tilers that create archives outside of (no compression | gzip). So I'm not sure how generally applicable this feature / option is until we have a push towards supporting brotli or zstd across the PMTiles ecosystem.

@lseelenbinder
Copy link
Author

The initial goal (and what this PR supports directly) is the first, but it opens the door for the second.

You're correct that MBTiles is underspecified, which is why we opted for a flag. We have internal tools that use brotli, and could conceivably used ZSTD when it has broader support. We'd also like to be able to convert gzip'ed mbtiles to other compressions in a single conversion step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants